Resolves the following error during stage one of clang-tidy-pr-comments:
"error: 'argparse/argparse.hpp' file not found [clang-diagnostic-error]"
Closes#219
Signed-off-by: Sean Robinson <sean.robinson@scottsdalecc.edu>
This action runs clang-tidy with results saved to a file which is then
parsed in stage two to post code comments. This multistage process lets
us post PR comments on code from forks.
Signed-off-by: Sean Robinson <sean.robinson@scottsdalecc.edu>
The new "windows-latest-clang" target does not honor the CXX environment
variable and uses the default MSVC compiler. This tries to tell cmake to
handle things via a toolset name.
Signed-off-by: Sean Robinson <sean.robinson@scottsdalecc.edu>
Several people using clang-cl on Windows are reporting build errors after
a upgrading to v13. This tries to replicate the error to allow testing
a fix.
Signed-off-by: Sean Robinson <sean.robinson@scottsdalecc.edu>
windows-latest changed to Windows 2022 during first quarter of 2022. This
adds windows-2019 to CI test matrix do that we can catch changes that break
the older configuration.
Signed-off-by: Sean Robinson <sean.robinson@scottsdalecc.edu>
I am seeing too many errors due to bad tool configuration, not from
problems in project code. So, disable SA until I can make it work more
reliably.
Signed-off-by: Sean Robinson <sean.robinson@scottsdalecc.edu>
Upstream StaticAnalysis looks to be changing for more flexibility with
source files to process. While these changes may eventually benefit
argparse, the public interfaces are in flux and we need a stable tool.
argparse also needs a SA change which is not yet upstream.
Trying to run clang-tidy via StaticAnalysis on a single file in a
directory with many source file is not easy, so move the analysis kernel
to a location (i.e. tools) where it is the only C++ source file.
Another benefit is cppcheck no longer needs to be told to ignore the test
sources.
Signed-off-by: Sean Robinson <sean.robinson@scottsdalecc.edu>
The GH security model restricts comment posting from PR actions.
StaticAnalysis has added support for pull_request_target to mitigate
risks while still allowing comments by the bot.
Signed-off-by: Sean Robinson <sean.robinson@scottsdalecc.edu>
Unit test source files are not currently checked. Hopefully, these can
be added so that all source files in a pull request are verified.
Signed-off-by: Sean Robinson <sean.robinson@scottsdalecc.edu>
Run tests on Apple macOS, MS Windows, and Ubuntu Linux hosts.
macOS-hosted tests are only run on latest, which is currently macOS 10.15.
GH will eventually update latest to macOS 11 and we can look at expanding
to two versions of macOS.
Windows-hosted tests run on Windows Server 2016 and latest.
Ubuntu-hosted tests only run on latest because g++ fails to build argparse
on ubuntu-18.04 (GCC 8) since charconv was added in commit ea2f16d2. But,
Ubuntu-hosted tests do run with g++ and clang++.
Closes#128.
Signed-off-by: Sean Robinson <sean.robinson@scottsdalecc.edu>
