clang-ci >= 13.0 is failing to compile a constexpr function pointer
assignment. This is possibly due to strtof (and family) not being
implemented as constexpr in the relevant libc++.
Closes#136Closes#156
Signed-off-by: Sean Robinson <sean.robinson@scottsdalecc.edu>
The new "windows-latest-clang" target does not honor the CXX environment
variable and uses the default MSVC compiler. This tries to tell cmake to
handle things via a toolset name.
Signed-off-by: Sean Robinson <sean.robinson@scottsdalecc.edu>
Several people using clang-cl on Windows are reporting build errors after
a upgrading to v13. This tries to replicate the error to allow testing
a fix.
Signed-off-by: Sean Robinson <sean.robinson@scottsdalecc.edu>
windows-latest changed to Windows 2022 during first quarter of 2022. This
adds windows-2019 to CI test matrix do that we can catch changes that break
the older configuration.
Signed-off-by: Sean Robinson <sean.robinson@scottsdalecc.edu>
Clears warnings for the following checks in clang-tidy:
readability-braces-around-statements
readability-else-after-return checks
Also adds hints about code style to CONTRIBUTING document.
Signed-off-by: Sean Robinson <sean.robinson@scottsdalecc.edu>
After upgrading g++ package to 12.1.0 on archlinux I see the following
compilation error:
/usr/include/argparse/argparse.hpp: In member function ‘void argparse::ArgumentParser::index_argument(list_iterator)’:
/usr/include/argparse/argparse.hpp:1167:34: error: ‘as_const’ is not a member of ‘std’; did you mean ‘is_const’?
1167 | for (const auto &name : std::as_const(it->m_names)) {
| ^~~~~~~~
| is_const
It turns out that std::as_const comes from <utility> header [1] which
was not explicitly included.
[1] https://en.cppreference.com/w/cpp/utility/as_const
As far as I can tell, this statement is never true.
When m_values.size() < *expected, ::consume has already thrown "Too few
arguments..." before ::validate is called.
When m_values.size() > *expected, ArgumentParser::parse_args_internal
has already thrown "Maximum number of positional arguments exceeded"
before ::validate is called.
If ::remaining is used to avoid the last exception, this Argument will
always consume the expected number of values, hence this expression is
again false.
Signed-off-by: Sean Robinson <sean.robinson@scottsdalecc.edu>
