KeqingMoe/argparse
1
0
Fork 0
mirror of https://github.com/KeqingMoe/argparse.git synced 2025-07-04 07:04:39 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Throw std::logic_error instead of returning empty value

Browse Source
This commit is contained in:
Stephan van Veen 2019-05-13 22:29:09 +02:00
parent 02b3ed1878
commit f08a280f92
1 changed files with 2 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
include/argparse.hpp
View File

@ -304,7 +304,7 @@ class ArgumentParser {
if (tIterator != mArgumentMap.end()) { if (tIterator != mArgumentMap.end()) {
return tIterator->second->get<T>(); return tIterator->second->get<T>();
} }
return T(); throw std::logic_error("No such argument");
} }
// Indexing operator. Return a reference to an Argument object // Indexing operator. Return a reference to an Argument object
@ -314,9 +314,7 @@ class ArgumentParser {
if (tIterator != mArgumentMap.end()) { if (tIterator != mArgumentMap.end()) {
return *(tIterator->second); return *(tIterator->second);
} }
else { throw std::logic_error("No such argument");
throw std::runtime_error("Argument " + aArgumentName + " not found");
}
} }
// Printing the one and only help message // Printing the one and only help message
@ -390,12 +388,6 @@ class ArgumentParser {
} }
private: private:
// If the argument was defined by the user and can be found in mArgumentMap, then it's valid
bool is_valid_argument(const std::string& aName) {
auto tIterator = mArgumentMap.find(aName);
return (tIterator != mArgumentMap.end());
}
/* /*
* @throws std::runtime_error in case of any invalid argument * @throws std::runtime_error in case of any invalid argument
*/ */