KeqingMoe/argparse
1
0
Fork 0
mirror of https://github.com/KeqingMoe/argparse.git synced 2025-07-04 07:04:39 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Merge pull request #253 from skrobinson/fix-string-crash

Browse Source 
Fix crash with char[] default values
This commit is contained in:
Pranav 2023-02-19 10:29:53 -06:00 committed by GitHub
commit e077137cd2
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 26 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
include/argparse/argparse.hpp
View File

@ -408,6 +408,10 @@ public:
return *this;
}
Argument &default_value(const char *value) {
return default_value(std::string(value));
}
Argument &required() {
m_is_required = true;
return *this;

1
test/CMakeLists.txt
View File

@ -33,6 +33,7 @@ file(GLOB ARGPARSE_TEST_SOURCES
test_container_arguments.cpp
test_const_correct.cpp
test_default_args.cpp
test_default_value.cpp
test_get.cpp
test_help.cpp
test_invalid_arguments.cpp

21
test/test_default_value.cpp Normal file
View File

@ -0,0 +1,21 @@
#include <argparse/argparse.hpp>
#include <doctest.hpp>
#include <string>
using doctest::test_suite;
TEST_CASE("Use a 'string' default value" * test_suite("default_value")) {
argparse::ArgumentParser program("test");
SUBCASE("Use a const char[] default value") {
program.add_argument("--arg").default_value("array of char");
REQUIRE_NOTHROW(program.parse_args({"test"}));
REQUIRE(program.get("--arg") == std::string("array of char"));
}
SUBCASE("Use a std::string default value") {
program.add_argument("--arg").default_value(std::string("string object"));
REQUIRE_NOTHROW(program.parse_args({"test"}));
REQUIRE(program.get("--arg") == std::string("string object"));
}
}