KeqingMoe/argparse
1
0
Fork 0
mirror of https://github.com/KeqingMoe/argparse.git synced 2025-07-04 15:14:39 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Remove sentry check in ArgumentParser::operator<<

Browse Source 
cppcheck reports "Variable 'sen' is assigned a value that is never used.
[unreadVariable]" for this line.

As far as I understand, std::ostream::sentry is used to prepare access to
the stream buffer.  But, we are never directly accessing the stream
buffer.  Stream access in this function uses other operator<< functions.

Most noise in this patch is about unindenting after if() removal.

Signed-off-by: Sean Robinson <sean.robinson@scottsdalecc.edu>
This commit is contained in:
Sean Robinson 2021-11-10 13:54:35 -07:00
parent abb2206141
commit c0bbcf613c
1 changed files with 29 additions and 31 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

60
include/argparse/argparse.hpp
View File

@ -1002,39 +1002,37 @@ public:
// Print help message
friend auto operator<<(std::ostream &stream, const ArgumentParser &parser)
-> std::ostream & {
if (auto sen = std::ostream::sentry(stream)) {
stream.setf(std::ios_base::left);
stream << "Usage: " << parser.mProgramName << " [options] ";
std::size_t tLongestArgumentLength = parser.get_length_of_longest_argument();
stream.setf(std::ios_base::left);
stream << "Usage: " << parser.mProgramName << " [options] ";
std::size_t tLongestArgumentLength = parser.get_length_of_longest_argument();
for (const auto &argument : parser.mPositionalArguments) {
stream << argument.mNames.front() << " ";
}
stream << "\n\n";
if (!parser.mDescription.empty())
stream << parser.mDescription << "\n\n";
if (!parser.mPositionalArguments.empty())
stream << "Positional arguments:\n";
for (const auto &mPositionalArgument : parser.mPositionalArguments) {
stream.width(tLongestArgumentLength);
stream << mPositionalArgument;
}
if (!parser.mOptionalArguments.empty())
stream << (parser.mPositionalArguments.empty() ? "" : "\n")
<< "Optional arguments:\n";
for (const auto &mOptionalArgument : parser.mOptionalArguments) {
stream.width(tLongestArgumentLength);
stream << mOptionalArgument;
}
if (!parser.mEpilog.empty())
stream << parser.mEpilog << "\n\n";
for (const auto &argument : parser.mPositionalArguments) {
stream << argument.mNames.front() << " ";
}
stream << "\n\n";
if (!parser.mDescription.empty())
stream << parser.mDescription << "\n\n";
if (!parser.mPositionalArguments.empty())
stream << "Positional arguments:\n";
for (const auto &mPositionalArgument : parser.mPositionalArguments) {
stream.width(tLongestArgumentLength);
stream << mPositionalArgument;
}
if (!parser.mOptionalArguments.empty())
stream << (parser.mPositionalArguments.empty() ? "" : "\n")
<< "Optional arguments:\n";
for (const auto &mOptionalArgument : parser.mOptionalArguments) {
stream.width(tLongestArgumentLength);
stream << mOptionalArgument;
}
if (!parser.mEpilog.empty())
stream << parser.mEpilog << "\n\n";
return stream;
}