KeqingMoe/argparse
1
0
Fork 0
mirror of https://github.com/KeqingMoe/argparse.git synced 2025-07-04 15:14:39 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Enable clang-tidy's readability-qualified-auto check

Browse Source 
Following the clang-tidy suggested fix in consume_digits causes compile
failures with MSVC 19.29 in our CI.

Signed-off-by: Sean Robinson <sean.robinson@scottsdalecc.edu>
This commit is contained in:
Sean Robinson 2022-02-09 15:27:16 -07:00
parent b5fb663bc8
commit bd4837f240
2 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
.clang-tidy
View File

@ -3,7 +3,6 @@ Checks:
readability-*, readability-*,
-readability-else-after-return, -readability-else-after-return,
-readability-function-cognitive-complexity, -readability-function-cognitive-complexity,
-readability-qualified-auto,
-readability-static-accessed-through-instance, -readability-static-accessed-through-instance,
CheckOptions: CheckOptions:

7
include/argparse/argparse.hpp
View File

@ -670,6 +670,7 @@ private:
// precondition: we have consumed or will consume at least one digit // precondition: we have consumed or will consume at least one digit
auto consume_digits = [=](std::string_view s) { auto consume_digits = [=](std::string_view s) {
// NOLINTNEXTLINE(readability-qualified-auto)
auto it = std::find_if_not(std::begin(s), std::end(s), is_digit); auto it = std::find_if_not(std::begin(s), std::end(s), is_digit);
return s.substr(it - std::begin(s)); return s.substr(it - std::begin(s));
}; };
@ -936,12 +937,12 @@ public:
template <typename... Targs> template <typename... Targs>
ArgumentParser &add_parents(const Targs &... Fargs) { ArgumentParser &add_parents(const Targs &... Fargs) {
for (const ArgumentParser &tParentParser : {std::ref(Fargs)...}) { for (const ArgumentParser &tParentParser : {std::ref(Fargs)...}) {
for (auto &tArgument : tParentParser.mPositionalArguments) { for (const auto &tArgument : tParentParser.mPositionalArguments) {
auto it = auto it =
mPositionalArguments.insert(cend(mPositionalArguments), tArgument); mPositionalArguments.insert(cend(mPositionalArguments), tArgument);
index_argument(it); index_argument(it);
} }
for (auto &tArgument : tParentParser.mOptionalArguments) { for (const auto &tArgument : tParentParser.mOptionalArguments) {
auto it = auto it =
mOptionalArguments.insert(cend(mOptionalArguments), tArgument); mOptionalArguments.insert(cend(mOptionalArguments), tArgument);
index_argument(it); index_argument(it);
@ -1173,7 +1174,7 @@ private:
using list_iterator = std::list<Argument>::iterator; using list_iterator = std::list<Argument>::iterator;
void index_argument(list_iterator argIt) { void index_argument(list_iterator argIt) {
for (auto &mName : std::as_const(argIt->mNames)) { for (const auto &mName : std::as_const(argIt->mNames)) {
mArgumentMap.insert_or_assign(mName, argIt); mArgumentMap.insert_or_assign(mName, argIt);
} }
} }