KeqingMoe/argparse
1
0
Fork 0
mirror of https://github.com/KeqingMoe/argparse.git synced 2025-07-04 15:14:39 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Enable clang-tidy readability-magic-numbers check

Browse Source 
Adds names for integer bases used with details::parse_number.

Signed-off-by: Sean Robinson <sean.robinson@scottsdalecc.edu>
This commit is contained in:
Sean Robinson 2022-02-07 14:29:25 -07:00
parent b918763adf
commit 9eb1fe5cef
2 changed files with 13 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
.clang-tidy
View File

@ -3,7 +3,6 @@ Checks:
readability-*, readability-*,
-readability-else-after-return, -readability-else-after-return,
-readability-function-cognitive-complexity, -readability-function-cognitive-complexity,
-readability-magic-numbers,
-readability-named-parameter, -readability-named-parameter,
-readability-qualified-auto, -readability-qualified-auto,
-readability-static-accessed-through-instance, -readability-static-accessed-through-instance,

22
include/argparse/argparse.hpp
View File

@ -140,6 +140,10 @@ constexpr bool standard_unsigned_integer<unsigned long long int> = true;
} // namespace } // namespace
constexpr int radix_8 = 8;
constexpr int radix_10 = 10;
constexpr int radix_16 = 16;
template <typename T> template <typename T>
constexpr bool standard_integer = constexpr bool standard_integer =
standard_signed_integer<T> || standard_unsigned_integer<T>; standard_signed_integer<T> || standard_unsigned_integer<T>;
@ -219,10 +223,10 @@ template <class T, auto Param = 0> struct parse_number {
} }
}; };
template <class T> struct parse_number<T, 16> { template <class T> struct parse_number<T, radix_16> {
auto operator()(std::string_view s) -> T { auto operator()(std::string_view s) -> T {
if (auto [ok, rest] = consume_hex_prefix(s); ok) { if (auto [ok, rest] = consume_hex_prefix(s); ok) {
return do_from_chars<T, 16>(rest); return do_from_chars<T, radix_16>(rest);
} else { } else {
throw std::invalid_argument{"pattern not found"}; throw std::invalid_argument{"pattern not found"};
} }
@ -232,11 +236,11 @@ template <class T> struct parse_number<T, 16> {
template <class T> struct parse_number<T> { template <class T> struct parse_number<T> {
auto operator()(std::string_view s) -> T { auto operator()(std::string_view s) -> T {
if (auto [ok, rest] = consume_hex_prefix(s); ok) { if (auto [ok, rest] = consume_hex_prefix(s); ok) {
return do_from_chars<T, 16>(rest); return do_from_chars<T, radix_16>(rest);
} else if (starts_with("0"sv, s)) { } else if (starts_with("0"sv, s)) {
return do_from_chars<T, 8>(rest); return do_from_chars<T, radix_8>(rest);
} else { } else {
return do_from_chars<T, 10>(rest); return do_from_chars<T, radix_10>(rest);
} }
} }
}; };
@ -418,18 +422,18 @@ public:
}; };
if constexpr (is_one_of(Shape, 'd') && details::standard_integer<T>) { if constexpr (is_one_of(Shape, 'd') && details::standard_integer<T>) {
action(details::parse_number<T, 10>()); action(details::parse_number<T, details::radix_10>());
} else if constexpr (is_one_of(Shape, 'i') && details::standard_integer<T>) { } else if constexpr (is_one_of(Shape, 'i') && details::standard_integer<T>) {
action(details::parse_number<T>()); action(details::parse_number<T>());
} else if constexpr (is_one_of(Shape, 'u') && } else if constexpr (is_one_of(Shape, 'u') &&
details::standard_unsigned_integer<T>) { details::standard_unsigned_integer<T>) {
action(details::parse_number<T, 10>()); action(details::parse_number<T, details::radix_10>());
} else if constexpr (is_one_of(Shape, 'o') && } else if constexpr (is_one_of(Shape, 'o') &&
details::standard_unsigned_integer<T>) { details::standard_unsigned_integer<T>) {
action(details::parse_number<T, 8>()); action(details::parse_number<T, details::radix_8>());
} else if constexpr (is_one_of(Shape, 'x', 'X') && } else if constexpr (is_one_of(Shape, 'x', 'X') &&
details::standard_unsigned_integer<T>) { details::standard_unsigned_integer<T>) {
action(details::parse_number<T, 16>()); action(details::parse_number<T, details::radix_16>());
} else if constexpr (is_one_of(Shape, 'a', 'A') && } else if constexpr (is_one_of(Shape, 'a', 'A') &&
std::is_floating_point_v<T>) { std::is_floating_point_v<T>) {
action(details::parse_number<T, details::chars_format::hex>()); action(details::parse_number<T, details::chars_format::hex>());