KeqingMoe/argparse
1
0
Fork 0
mirror of https://github.com/KeqingMoe/argparse.git synced 2025-07-04 15:14:39 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Improve thrown message in case of invalid argument.

Browse Source 
Now message contains information which argument is the source of error.
It's easier to spot typo/understand which part of more complex command
is the source of problem.
This commit is contained in:
Maciej Patro 2021-11-05 09:56:17 +01:00
parent b9583b42ab
commit 87afaba6ba
3 changed files with 6 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
include/argparse/argparse.hpp
View File

@ -1089,11 +1089,11 @@ private:
auto tArgument = tIterator2->second; auto tArgument = tIterator2->second;
it = tArgument->consume(it, end, tIterator2->first); it = tArgument->consume(it, end, tIterator2->first);
} else { } else {
throw std::runtime_error("Unknown argument"); throw std::runtime_error("Unknown argument: " + tCurrentArgument);
} }
} }
} else { } else {
throw std::runtime_error("Unknown argument"); throw std::runtime_error("Unknown argument: " + tCurrentArgument);
} }
} }
mIsParsed = true; mIsParsed = true;

3
test/test_invalid_arguments.cpp
View File

@ -36,5 +36,6 @@ TEST_CASE("Parse unknown optional argument" *
.scan<'u', unsigned long long>() .scan<'u', unsigned long long>()
.help("memory in MB to give the VMM when loading"); .help("memory in MB to give the VMM when loading");
REQUIRE_THROWS(bfm.parse_args({ "./test.exe", "-om" })); REQUIRE_THROWS_WITH_AS(bfm.parse_args({"./test.exe", "-om"}),
"Unknown argument: -om", std::runtime_error);
} }

4
test/test_version.cpp
View File

@ -16,8 +16,8 @@ TEST_CASE("Users can print version and exit" * test_suite("version")
TEST_CASE("Users can disable default -v/--version" * test_suite("version")) { TEST_CASE("Users can disable default -v/--version" * test_suite("version")) {
argparse::ArgumentParser program("test", "1.0", argparse::ArgumentParser program("test", "1.0",
argparse::default_arguments::help); argparse::default_arguments::help);
REQUIRE_THROWS_AS(program.parse_args({"test", "--version"}), REQUIRE_THROWS_WITH_AS(program.parse_args({"test", "--version"}),
std::runtime_error); "Unknown argument: --version", std::runtime_error);
} }
TEST_CASE("Users can replace default -v/--version" * test_suite("version")) { TEST_CASE("Users can replace default -v/--version" * test_suite("version")) {