From 7dd6655a9ecb997a2a4f216154229de2814212ec Mon Sep 17 00:00:00 2001 From: Zhihao Yuan Date: Sat, 16 Nov 2019 22:14:14 -0600 Subject: [PATCH] Avoid extra copy made by initializer_list --- include/argparse.hpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/argparse.hpp b/include/argparse.hpp index 253cea9..c965f9a 100644 --- a/include/argparse.hpp +++ b/include/argparse.hpp @@ -416,7 +416,7 @@ public: // Parameter packed add_parents method // Accepts a variadic number of ArgumentParser objects template void add_parents(const Targs &... Fargs) { - for (auto &tParentParser : {Fargs...}) { + for (const ArgumentParser &tParentParser : {std::ref(Fargs)...}) { for (auto &tArgument : tParentParser.mPositionalArguments) { auto it = mPositionalArguments.insert(cend(mPositionalArguments), tArgument);