KeqingMoe/argparse
1
0
Fork 0
mirror of https://github.com/KeqingMoe/argparse.git synced 2025-07-04 15:14:39 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Use stl algorithms instead of nested for loops

Browse Source
This commit is contained in:
Stephan van Veen 2019-05-11 12:24:01 +02:00
parent a364f3f1e7
commit 7c938b1f2b
1 changed files with 13 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

27
include/argparse.hpp
View File

@ -40,6 +40,7 @@ SOFTWARE.
#include <algorithm>
#include <sstream>
#include <stdexcept>
#include <numeric>
namespace argparse {
@ -635,19 +636,17 @@ class ArgumentParser {
// Used by print_help.
size_t get_length_of_longest_argument(const std::vector<std::shared_ptr<Argument>>& aArguments) {
size_t tResult = 0;
for (const auto& argument : aArguments) {
size_t tCurrentArgumentLength = 0;
auto tNames = argument->mNames;
for (size_t j = 0; j < tNames.size() - 1; j++) {
auto tNameLength = tNames[j].length();
tCurrentArgumentLength += tNameLength + 2; // +2 for ", "
}
tCurrentArgumentLength += tNames[tNames.size() - 1].length();
if (tCurrentArgumentLength > tResult)
tResult = tCurrentArgumentLength;
}
return tResult;
if (aArguments.empty())
return 0;
std::vector<size_t> argumentLengths(aArguments.size());
std::transform(std::begin(aArguments), std::end(aArguments), std::begin(argumentLengths), [](const auto& arg) {
const auto& names = arg->mNames;
auto maxLength = std::accumulate(std::begin(names), std::end(names), 0, [](const auto& sum, const auto& s) {
return sum + s.size() + 2; // +2 for ", "
});
return maxLength - 2; // -2 since the last one doesn't need ", "
});
return *std::max_element(std::begin(argumentLengths), std::end(argumentLengths));
}
// Used by print_help.
@ -670,7 +669,7 @@ class ArgumentParser {
try { \
parser.parse_args(argc, argv); \
} catch (const std::runtime_error& err) { \
std::cerr << err.what() << std::endl; \
std::cout << err.what() << std::endl; \
parser.print_help(); \
exit(0); \
}