KeqingMoe/argparse
1
0
Fork 0
mirror of https://github.com/KeqingMoe/argparse.git synced 2025-07-03 22:54:39 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Merge pull request #292 from BitMaskMixer/gcc_warning_fix

Browse Source 
CMakefile: Use -Wpedantic, -Werror and -Wextra for compilation in gcc. Fixed warnings
This commit is contained in:
Pranav 2023-10-20 18:46:07 -05:00 committed by GitHub
commit 5614b96e5a
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
CMakeLists.txt
View File

@ -8,7 +8,7 @@ project(argparse
) )
option(ARGPARSE_INSTALL "Include an install target" ON) option(ARGPARSE_INSTALL "Include an install target" ON)
option(ARGPARSE_BUILD_TESTS "Build tests" OFF) option(ARGPARSE_BUILD_TESTS "Build tests" ON)
include(GNUInstallDirs) include(GNUInstallDirs)
include(CMakePackageConfigHelpers) include(CMakePackageConfigHelpers)

4
include/argparse/argparse.hpp
View File

@ -680,8 +680,8 @@ public:
// align multiline help message // align multiline help message
auto stream_width = stream.width(); auto stream_width = stream.width();
auto name_padding = std::string(name_stream.str().size(), ' '); auto name_padding = std::string(name_stream.str().size(), ' ');
auto pos = 0; auto pos = std::string::size_type{};
auto prev = 0; auto prev = std::string::size_type{};
auto first_line = true; auto first_line = true;
auto hspace = " "; // minimal space between name and help message auto hspace = " "; // minimal space between name and help message
stream << name_stream.str(); stream << name_stream.str();

2
test/CMakeLists.txt
View File

@ -10,7 +10,7 @@ if(MSVC)
endif() endif()
elseif(CMAKE_COMPILER_IS_GNUCC OR CMAKE_COMPILER_IS_GNUCXX) elseif(CMAKE_COMPILER_IS_GNUCC OR CMAKE_COMPILER_IS_GNUCXX)
# Update if necessary # Update if necessary
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wall -Wno-long-long -pedantic -Wsign-conversion -Wshadow -Wconversion") set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wall -Wno-long-long -Wpedantic -Wsign-conversion -Wshadow -Wconversion -Werror -Wextra")
endif() endif()
if(NOT CMAKE_BUILD_TYPE) if(NOT CMAKE_BUILD_TYPE)

4
test/test_help.cpp
View File

@ -104,7 +104,7 @@ R"(#Lorem ipsum dolor sit amet, consectetur adipiscing elit.
stream << program; stream << program;
std::istringstream iss(stream.str()); std::istringstream iss(stream.str());
int help_message_start = -1; auto help_message_start = std::string::npos;
std::string line; std::string line;
while (std::getline(iss, line)) { while (std::getline(iss, line)) {
// Find the position of '#', which indicates the start of the help message line // Find the position of '#', which indicates the start of the help message line
@ -114,7 +114,7 @@ R"(#Lorem ipsum dolor sit amet, consectetur adipiscing elit.
continue; continue;
} }
if (help_message_start == -1) { if (help_message_start == std::string::npos) {
help_message_start = pos; help_message_start = pos;
} else { } else {
REQUIRE(pos == help_message_start); REQUIRE(pos == help_message_start);