From 0b74da54d43f021325e2a1cbfb78a7adc6fda9a9 Mon Sep 17 00:00:00 2001 From: Sean Robinson Date: Mon, 7 Feb 2022 14:29:32 -0700 Subject: [PATCH] Enable clang-tidy cppcoreguidelines-special-member-functions check Also adds a default destructor, as recommended by the check. Signed-off-by: Sean Robinson --- .clang-tidy | 1 + include/argparse/argparse.hpp | 2 ++ 2 files changed, 3 insertions(+) diff --git a/.clang-tidy b/.clang-tidy index c1dd300..6dd99da 100644 --- a/.clang-tidy +++ b/.clang-tidy @@ -1,5 +1,6 @@ Checks: -*, + cppcoreguidelines-special-member-functions, readability-*, -readability-else-after-return, -readability-function-cognitive-complexity, diff --git a/include/argparse/argparse.hpp b/include/argparse/argparse.hpp index 112dbb0..9b08ea0 100644 --- a/include/argparse/argparse.hpp +++ b/include/argparse/argparse.hpp @@ -910,6 +910,8 @@ public: } } + ~ArgumentParser() = default; + ArgumentParser &operator=(const ArgumentParser &other) { auto tmp = other; std::swap(*this, tmp);